JiaqiWang18 commented on PR #51956: URL: https://github.com/apache/spark/pull/51956#issuecomment-3187214488
* refactored to use `ThreadUtils.newDaemonSingleThreadExecutor` to avoid the need of maintaining a queue manually. Each event is queued as a runnable task that sends the event. * implemented the `AutoCloseable` interface with try-with-resources to avoid the need of manual `shutdown()` call to avoid the caller forgetting, which could cause events to be lost. @jonmio could you take another pass? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
