jcw024 commented on code in PR #51687: URL: https://github.com/apache/spark/pull/51687#discussion_r2248798809
########## dev/requirements.txt: ########## @@ -76,7 +76,7 @@ graphviz==0.20.3 flameprof==0.4 # TorchDistributor dependencies -torch<2.6.0 +torch Review Comment: the torch pin was also added in .github/workflows/build_python_connect.yml and in several dev/spark-test-image python dockerfiles ([previous PR)](https://github.com/apache/spark/pull/49863/files#diff-cab8d808b530042ed863202e2d9d2419b942fa9fe18edc725df2a4f3206cf9b0). I think we should apply this change in those files as well to be consistent with the torch versions in the repo. Also, can you confirm that upgrading the torch version will not cause this issue [reported here](https://github.com/apache/spark/pull/49863#issuecomment-2647094992) when the docker file is rebuilt? seems like that was the reason the pin was added -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
