uros-db commented on code in PR #51576: URL: https://github.com/apache/spark/pull/51576#discussion_r2217692578
########## sql/core/src/test/scala/org/apache/spark/sql/TimeFunctionsSuite.scala: ########## @@ -0,0 +1,131 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.spark.sql + +import java.time.LocalTime + +import org.apache.spark.SparkConf +import org.apache.spark.sql.functions._ +import org.apache.spark.sql.internal.SQLConf +import org.apache.spark.sql.test.SharedSparkSession +import org.apache.spark.sql.types._ + +class TimeFunctionsSuite extends QueryTest with SharedSparkSession { + import testImplicits._ + + override def sparkConf: SparkConf = super.sparkConf.set(SQLConf.ANSI_ENABLED.key, "false") + + test("hour function") { Review Comment: We already have thorough testing of the underlying catalyst expressions in `TimeExpressionsSuite.scala`. These tests are intended to fully cover the expected behavior - incl. error handling, null handling, etc. The purpose in this PR is only to ensure that Scala API functions are properly documented and registered, as well as to provide minimal testing to ensure connectivity with the underlying catalyst expressions. With this in mind, I would propose to do only minimal testing as part of this PR, in order to avoid exploding the set of test-case scenarios (which are already covered in `TimeExpressionsSuite.scala`). Do you agree? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
