yaooqinn commented on code in PR #51189: URL: https://github.com/apache/spark/pull/51189#discussion_r2153569938
########## sql/core/src/main/scala/org/apache/spark/sql/columnar/CachedBatchSerializer.scala: ########## @@ -58,6 +60,39 @@ trait CachedBatchSerializer extends Serializable { */ def supportsColumnarInput(schema: Seq[Attribute]): Boolean + /** + * Attempt to convert a query plan to its columnar equivalence for columnar caching. + * Called on the query plan that is about to be cached once [[supportsColumnarInput]] returns + * true on its output schema. + * + * The default implementation works by stripping the topmost columnar-to-row transition to + * expose the columnar-based plan to the serializer. + * + * @param plan The plan to convert. + * @return The output plan. Could either be a columnar plan if the input plan is convertible, or + * the input plan unchanged if no viable conversion can be done. + */ + @Since("4.1.0") Review Comment: ```suggestion @DeveloperApi @Since("4.1.0") ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org