cloud-fan commented on code in PR #50959:
URL: https://github.com/apache/spark/pull/50959#discussion_r2113213727
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/ResolveDefaultColumnsUtil.scala:
##########
@@ -432,20 +432,20 @@ object ResolveDefaultColumns extends QueryErrorsBase
targetType: DataType,
colName: String): Option[Expression] = {
expr match {
- case l: Literal if !Seq(targetType, l.dataType).exists(_ match {
+ case e if e.foldable && !Seq(targetType, e.dataType).exists(_ match {
case _: BooleanType | _: ArrayType | _: StructType | _: MapType => true
case _ => false
}) =>
- val casted = Cast(l, targetType, Some(conf.sessionLocalTimeZone),
evalMode = EvalMode.TRY)
+ val casted = Cast(e, targetType, Some(conf.sessionLocalTimeZone),
evalMode = EvalMode.TRY)
try {
Option(casted.eval(EmptyRow)).map(Literal(_, targetType))
} catch {
- case e @ ( _: SparkThrowable | _: RuntimeException) =>
- logWarning(log"Failed to cast default value
'${MDC(COLUMN_DEFAULT_VALUE, l)}' " +
+ case ex @ ( _: SparkThrowable | _: RuntimeException) =>
Review Comment:
to be safe, can we match any exception here? If anything gets wrong we just
fail and say the type is incompatible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
