LuciferYang commented on code in PR #50999:
URL: https://github.com/apache/spark/pull/50999#discussion_r2104975035
##########
tools/src/main/scala/org/apache/spark/tools/GenerateMIMAIgnore.scala:
##########
@@ -157,7 +157,7 @@ object GenerateMIMAIgnore {
* and subpackages both from directories and jars present on the classpath.
*/
private def getClasses(packageName: String): Set[String] = {
- val finder = ClassFinder(maybeOverrideAsmVersion = Some(Opcodes.ASM7))
+ val finder = ClassFinder(maybeOverrideAsmVersion = Some(Opcodes.ASM8))
Review Comment:
for fix
```
Exception in thread "main" java.lang.UnsupportedOperationException: Record
requires ASM8
at
org.objectweb.asm.ClassVisitor.visitRecordComponent(ClassVisitor.java:323)
at
org.objectweb.asm.ClassReader.readRecordComponent(ClassReader.java:954)
at org.objectweb.asm.ClassReader.accept(ClassReader.java:732)
at org.objectweb.asm.ClassReader.accept(ClassReader.java:425)
at org.clapper.classutil.asm.ClassFile$.load(ClassFinderImpl.scala:224)
at org.clapper.classutil.ClassFinder.classData(ClassFinder.scala:404)
at
org.clapper.classutil.ClassFinder.$anonfun$processOpenZip$2(ClassFinder.scala:359)
at scala.collection.Iterator$$anon$9.next(Iterator.scala:584)
at scala.collection.Iterator$$anon$10.nextCur(Iterator.scala:594)
at scala.collection.Iterator$$anon$10.hasNext(Iterator.scala:608)
at
scala.collection.immutable.LazyList$.scala$collection$immutable$LazyList$$stateFromIterator(LazyList.scala:1195)
at
scala.collection.immutable.LazyList$.$anonfun$stateFromIterator$1(LazyList.scala:1195)
at
scala.collection.immutable.LazyList.scala$collection$immutable$LazyList$$state$lzycompute(LazyList.scala:282)
at
scala.collection.immutable.LazyList.scala$collection$immutable$LazyList$$state(LazyList.scala:273)
at scala.collection.immutable.LazyList.isEmpty(LazyList.scala:292)
at
scala.collection.immutable.LazyList.$anonfun$lazyAppendedAll$1(LazyList.scala:401)
at
scala.collection.immutable.LazyList.scala$collection$immutable$LazyList$$state$lzycompute(LazyList.scala:282)
at
scala.collection.immutable.LazyList.scala$collection$immutable$LazyList$$state(LazyList.scala:273)
at scala.collection.immutable.LazyList.isEmpty(LazyList.scala:292)
at
scala.collection.immutable.LazyList.$anonfun$lazyAppendedAll$1(LazyList.scala:401)
at
scala.collection.immutable.LazyList.scala$collection$immutable$LazyList$$state$lzycompute(LazyList.scala:282)
at
scala.collection.immutable.LazyList.scala$collection$immutable$LazyList$$state(LazyList.scala:273)
at scala.collection.immutable.LazyList.isEmpty(LazyList.scala:292)
at
scala.collection.immutable.LazyList.$anonfun$mapImpl$1(LazyList.scala:539)
at
scala.collection.immutable.LazyList.scala$collection$immutable$LazyList$$state$lzycompute(LazyList.scala:282)
at
scala.collection.immutable.LazyList.scala$collection$immutable$LazyList$$state(LazyList.scala:273)
at scala.collection.immutable.LazyList.isEmpty(LazyList.scala:292)
at
scala.collection.immutable.LazyList$.$anonfun$filterImpl$1(LazyList.scala:1036)
at
scala.collection.immutable.LazyList.scala$collection$immutable$LazyList$$state$lzycompute(LazyList.scala:282)
at
scala.collection.immutable.LazyList.scala$collection$immutable$LazyList$$state(LazyList.scala:273)
at scala.collection.immutable.LazyList.isEmpty(LazyList.scala:292)
at
scala.collection.immutable.LazyList$.$anonfun$filterImpl$1(LazyList.scala:1036)
at
scala.collection.immutable.LazyList.scala$collection$immutable$LazyList$$state$lzycompute(LazyList.scala:282)
at
scala.collection.immutable.LazyList.scala$collection$immutable$LazyList$$state(LazyList.scala:273)
at scala.collection.immutable.LazyList.isEmpty(LazyList.scala:292)
at
scala.collection.immutable.LazyList$LazyIterator.hasNext(LazyList.scala:1274)
at scala.collection.mutable.Growable.addAll(Growable.scala:61)
at scala.collection.mutable.Growable.addAll$(Growable.scala:57)
at scala.collection.immutable.SetBuilderImpl.addAll(Set.scala:405)
at scala.collection.immutable.Set$.from(Set.scala:362)
at scala.collection.IterableOnceOps.toSet(IterableOnce.scala:1469)
at scala.collection.IterableOnceOps.toSet$(IterableOnce.scala:1469)
at scala.collection.AbstractIterable.toSet(Iterable.scala:935)
at
org.apache.spark.tools.GenerateMIMAIgnore$.getClasses(GenerateMIMAIgnore.scala:165)
at
org.apache.spark.tools.GenerateMIMAIgnore$.privateWithin(GenerateMIMAIgnore.scala:64)
at
org.apache.spark.tools.GenerateMIMAIgnore$.main(GenerateMIMAIgnore.scala:131)
at
org.apache.spark.tools.GenerateMIMAIgnore.main(GenerateMIMAIgnore.scala)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
