urosstan-db commented on code in PR #50986:
URL: https://github.com/apache/spark/pull/50986#discussion_r2103353356
##########
connector/docker-integration-tests/src/test/scala/org/apache/spark/sql/jdbc/v2/V2JDBCTest.scala:
##########
@@ -1118,4 +1118,18 @@ private[v2] trait V2JDBCTest extends SharedSparkSession
with DockerIntegrationFu
testBinaryLiteral("<=>", greaterThanBinary, 0)
}
}
+
+ test("SPARK-52262: FAILED_JDBC.TABLE_EXISTS not thrown on connecttion
error") {
Review Comment:
nit: double t
```suggestion
test("SPARK-52262: FAILED_JDBC.TABLE_EXISTS not thrown on connection
error") {
```
Also, I would recommend naming function in a way to describe new positive
behaviour than to descirbe it to old negative behaviour
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
