gengliangwang commented on code in PR #50982:
URL: https://github.com/apache/spark/pull/50982#discussion_r2102932267
##########
sql/core/src/test/scala/org/apache/spark/sql/connector/DeleteFromTableSuiteBase.scala:
##########
@@ -63,6 +63,31 @@ abstract class DeleteFromTableSuiteBase extends
RowLevelOperationSuiteBase {
Row(6, "hr", "new-text")))
}
+ test("delete from table with table constraints") {
+ sql(
+ s"""
+ |CREATE TABLE $tableNameAsString (
+ | pk INT NOT NULL PRIMARY KEY,
+ | id INT UNIQUE,
+ | dep STRING,
+ | CONSTRAINT pk_check CHECK (pk > 0))
Review Comment:
yes, ideally we should skip adding the check constraint filter for DELETE.
This PR is more of adding tests to ensure delete works with constraints.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
