wecharyu commented on code in PR #48668: URL: https://github.com/apache/spark/pull/48668#discussion_r2101996196
########## sql/hive/src/test/scala/org/apache/spark/sql/hive/HiveExternalCatalogSuite.scala: ########## @@ -241,4 +242,33 @@ class HiveExternalCatalogSuite extends ExternalCatalogSuite { val alteredTable = externalCatalog.getTable("db1", tableName) assert(DataTypeUtils.sameType(alteredTable.schema, newSchema)) } + + test("SPARK-50137: Avoid fallback to Hive-incompatible ways on thrift exception") { + val hadoopConf = new Configuration() + // Use an unavailable uri to mock client connection timeout. + hadoopConf.set("hive.metastore.uris", "thrift://1.1.1.1:1111") Review Comment: Thanks for pointing that out. Change the real ip to a reserved address `192.0.2.1` in #50985 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org