dongjoon-hyun commented on code in PR #48668:
URL: https://github.com/apache/spark/pull/48668#discussion_r2100626614
##########
sql/hive/src/test/scala/org/apache/spark/sql/hive/HiveExternalCatalogSuite.scala:
##########
@@ -241,4 +242,33 @@ class HiveExternalCatalogSuite extends
ExternalCatalogSuite {
val alteredTable = externalCatalog.getTable("db1", tableName)
assert(DataTypeUtils.sameType(alteredTable.schema, newSchema))
}
+
+ test("SPARK-50137: Avoid fallback to Hive-incompatible ways on thrift
exception") {
+ val hadoopConf = new Configuration()
+ // Use an unavailable uri to mock client connection timeout.
+ hadoopConf.set("hive.metastore.uris", "thrift://1.1.1.1:1111")
Review Comment:
Oh, can we avoid to use `1.1.1.1` here, @wecharyu and @sunchao ? This looks
like a DDoS attach to `1.1.1.1`.
```
$ ping 1.1.1.1
PING 1.1.1.1 (1.1.1.1): 56 data bytes
64 bytes from 1.1.1.1: icmp_seq=0 ttl=59 time=3.495 ms
64 bytes from 1.1.1.1: icmp_seq=1 ttl=59 time=4.108 ms
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
