gengliangwang commented on code in PR #50943: URL: https://github.com/apache/spark/pull/50943#discussion_r2096591575
########## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala: ########## @@ -419,6 +419,10 @@ class Analyzer(override val catalogManager: CatalogManager) extends RuleExecutor ResolveRowLevelCommandAssignments :: MoveParameterizedQueriesDown :: BindParameters :: + ResolveEncodersInUDF :: Review Comment: I am moving the rules in to the main resolution batch, so that UDF encoders and table constraints can ben correctly handled in DML writes. cc @viirya @Ngone51 @aokolnychyi ########## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala: ########## @@ -419,6 +419,10 @@ class Analyzer(override val catalogManager: CatalogManager) extends RuleExecutor ResolveRowLevelCommandAssignments :: MoveParameterizedQueriesDown :: BindParameters :: + ResolveEncodersInUDF :: Review Comment: I am moving the rules in to the main resolution batch, so that UDF encoders and table constraints can be correctly handled in DML writes. cc @viirya @Ngone51 @aokolnychyi -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org