hvanhovell commented on code in PR #49785:
URL: https://github.com/apache/spark/pull/49785#discussion_r2093745119
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/DeserializerBuildHelper.scala:
##########
@@ -406,14 +406,20 @@ object DeserializerBuildHelper {
NewInstance(cls, arguments, Nil, propagateNull = false, dt,
outerPointerGetter))
case AgnosticEncoders.RowEncoder(fields) =>
+ val isExternalRow = !path.dataType.isInstanceOf[StructType]
Review Comment:
It should be. If you don't know the dataType at this point, then you can't
build a deserializer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
