peter-toth commented on code in PR #50925:
URL: https://github.com/apache/spark/pull/50925#discussion_r2093609623
##########
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/features/BasicDriverFeatureStep.scala:
##########
@@ -99,6 +99,9 @@ private[spark] class BasicDriverFeatureStep(conf:
KubernetesDriverConf)
conf.sparkConf.getInt(BLOCK_MANAGER_PORT.key, DEFAULT_BLOCKMANAGER_PORT)
)
val driverUIPort = SparkUI.getUIPort(conf.sparkConf)
+ // To avoid a new compile dependency, we use the string config name and
default value.
+ val driverSparkConnectServerPort =
+ conf.sparkConf.getInt("spark.connect.grpc.binding.port", 15002)
Review Comment:
And maybe extracting `spark.connect.grpc.binding.port` out to `Constants`
would make sense too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
