ericm-db commented on code in PR #50924: URL: https://github.com/apache/spark/pull/50924#discussion_r2093474517
########## sql/core/src/test/scala/org/apache/spark/sql/execution/streaming/state/RocksDBStateStoreSuite.scala: ########## @@ -2098,6 +2098,7 @@ class RocksDBStateStoreSuite extends StateStoreSuiteBase[RocksDBStateStoreProvid useMultipleValuesPerKey: Boolean = false): RocksDBStateStoreProvider = { val provider = new RocksDBStateStoreProvider() val testStateSchemaProvider = new TestStateSchemaProvider + conf.set(StreamExecution.RUN_ID_KEY, UUID.randomUUID().toString) Review Comment: Because we no longer have the isTesting check and unconditionally assert that runId should not be null, those tests would just fail. Without this fix, all of those tests were failing with runId being equal to null. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org