szehon-ho commented on code in PR #50864:
URL: https://github.com/apache/spark/pull/50864#discussion_r2093402946
##########
sql/catalyst/src/main/java/org/apache/spark/sql/connector/catalog/TableChange.java:
##########
@@ -726,22 +746,29 @@ public String[] fieldNames() {
* is not provided as updating column default values does not need to
back-fill existing data.
* Empty string means dropping the column default value.
*/
- public String newDefaultValue() { return newDefaultValue; }
+ public String newDefaultValue() {
+ return newCurrentDefault == null ? "" : newCurrentDefault.getSql();
+ }
+
+ /**
+ * Returns the column default value as {@link DefaultValue} with a
+ * {@link org.apache.spark.sql.connector.expressions.Expression}. The
default value literal
+ * is not provided as updating column default values does not need to
back-fill existing data.
+ * Null means dropping the column default value.
+ */
+ public DefaultValue newCurrentDefault() { return newCurrentDefault; }
@Override
public boolean equals(Object o) {
Review Comment:
ah sorry i used wrong template in Intellij
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
