urosstan-db commented on code in PR #50886:
URL: https://github.com/apache/spark/pull/50886#discussion_r2093271797
##########
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/v2/V2SessionCatalogSuite.scala:
##########
@@ -121,6 +121,33 @@ class V2SessionCatalogTableSuite extends
V2SessionCatalogBaseSuite {
catalog.dropTable(ident3)
}
+ test("listTableSummaries") {
+ val namespace = Array("ns")
+ val catalog = newCatalog()
+ val identManaged = Identifier.of(namespace, "managed_table")
+ val identExternal = Identifier.of(namespace, "external_table")
+
+ assert(catalog.listTableSummaries(namespace).isEmpty)
+
+ val externalTableProperties = Map(
+ TableCatalog.PROP_EXTERNAL -> "1",
+ TableCatalog.PROP_LOCATION -> "s3://"
Review Comment:
No, it does not validate it for creation
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/connector/catalog/V1Table.scala:
##########
@@ -79,6 +79,9 @@ private[sql] object V1Table {
def addV2TableProperties(v1Table: CatalogTable): Map[String, String] = {
val external = v1Table.tableType == CatalogTableType.EXTERNAL
val managed = v1Table.tableType == CatalogTableType.MANAGED
+ val tableTypeProperties: Map[String, String] = getV2TableType(v1Table)
Review Comment:
Makes sense, code would be cleaner
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
