mihailoale-db commented on code in PR #50858: URL: https://github.com/apache/spark/pull/50858#discussion_r2084221497
########## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/NormalizePlan.scala: ########## @@ -154,15 +154,14 @@ object NormalizePlan extends PredicateHelper { .getTagValue(DeduplicateRelations.PROJECT_FOR_EXPRESSION_ID_DEDUPLICATION) .isDefined => project.child + case Project(outerProjectList, innerProject: Project) => Review Comment: This doesn't seem correct. What if the first `Project` is the outermost one, we are going to normalize it as well? Please either change the approach or the title. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org