LuciferYang commented on PR #50798: URL: https://github.com/apache/spark/pull/50798#issuecomment-2860010408
@yaooqinn @cloud-fan I've noticed that the `connect-client-jvm` module still relies on the `core` module during runtime. For example, the `SparkConf` object passed to the `org.apache.spark.sql.connect.SparkSession.Builder#config` API is actually defined in the `core` module. If this dependency is intentional, could the `sql-api` module also include `core` as a compile-time dependency? This approach might allow us to reduce the number of stub classes defined in `shims.scala`, such as `SparkContext`, `SparkConf`, `JavaRDD`, and `RDD`. Consequently, this could potentially minimize the changes required in this pr. I’m currently testing this idea in https://github.com/apache/spark/pull/50815 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
