szehon-ho commented on code in PR #50792:
URL: https://github.com/apache/spark/pull/50792#discussion_r2078340204
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/connector/catalog/CatalogV2Util.scala:
##########
@@ -598,10 +598,28 @@ private[sql] object CatalogV2Util {
// data unchanged and let the data reader to return "exist
default" for missing
// columns.
val existingDefault = Literal(default.getValue.value(),
default.getValue.dataType()).sql
-
f.withExistenceDefaultValue(existingDefault).withCurrentDefaultValue(default.getSql)
+
f.withExistenceDefaultValue(existingDefault).withCurrentDefaultValue(toSql(defaultValue))
Review Comment:
i mean the method javadoc:
```// For built-in file sources, we encode the default value in StructField
metadata. An analyzer
// rule will check the special metadata and change the DML input plan to
fill the default value.```
do we need to update it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
