dongjoon-hyun commented on PR #50798: URL: https://github.com/apache/spark/pull/50798#issuecomment-2856981980
Technically, I don't have a suggestion to make it work. However, I can see this PR could have an undesirable side effect not only for now but forever because this PR seems unintentionally to advert `SparkContext` again by exposing more and more to new developers in Spark code base. According to this PR's claim, after this PR, I'm worrying if new developers also could add more `SparkContext` instances into the Spark code repository via the following patterns to keep the type annotations. What is your opinion about that? ``` val sc: SparkContext = spark.sparkContext ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org