dtenedor commented on code in PR #50805: URL: https://github.com/apache/spark/pull/50805#discussion_r2076623925
########## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/trees/TreePatterns.scala: ########## @@ -110,8 +105,28 @@ object TreePattern extends Enumeration { val UP_CAST: Value = Value val DISTRIBUTED_SEQUENCE_ID: Value = Value + // Unresolved expression patterns (Alphabetically ordered) + val UNRESOLVED_ALIAS: Value = Value + val UNRESOLVED_ATTRIBUTE: Value = Value + val UNRESOLVED_COLLATION: Value = Value + val UNRESOLVED_DESERIALIZER: Value = Value + val UNRESOLVED_DF_STAR: Value = Value + val UNRESOLVED_HAVING: Value = Value + val UNRESOLVED_IDENTIFIER: Value = Value + val UNRESOLVED_ORDINAL: Value = Value + val UNRESOLVED_FUNCTION: Value = Value + val UNRESOLVED_HINT: Value = Value + val UNRESOLVED_WINDOW_EXPRESSION: Value = Value + val UNRESOLVED_PLAN_ID: Value = Value Review Comment: Let's sort this sub group alphabetically as well? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org