cloud-fan commented on code in PR #50797: URL: https://github.com/apache/spark/pull/50797#discussion_r2074596294
########## connector/kafka-0-10-token-provider/src/main/scala/org/apache/spark/kafka010/KafkaConfigUpdater.scala: ########## @@ -30,7 +30,7 @@ import org.apache.spark.internal.Logging /** * Class to conveniently update Kafka config params, while logging the changes */ -private[spark] case class KafkaConfigUpdater(module: String, kafkaParams: Map[String, Object]) Review Comment: 4.0 added one new internal class in this package: `KafkaTokenProviderExceptions`. Given that this package contains only internal classes, I marked the entire `org.apache.spark.kafka010` package as private, so that we no longer need `private[spark]` in these existing classes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
