anishshri-db commented on code in PR #50795:
URL: https://github.com/apache/spark/pull/50795#discussion_r2074481583


##########
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/HDFSBackedStateStoreProvider.scala:
##########
@@ -113,6 +113,18 @@ private[sql] class HDFSBackedStateStoreProvider extends 
StateStoreProvider with
     case object COMMITTED extends STATE
     case object ABORTED extends STATE
 
+    Option(TaskContext.get()).foreach { ctxt =>
+      ctxt.addTaskCompletionListener[Unit]( ctx => {

Review Comment:
   Can we also add a note about the order in which these listeners fire and 
ensure that any change touching this part does not violate the underlying 
assumptions ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to