WeichenXu123 commented on code in PR #50751:
URL: https://github.com/apache/spark/pull/50751#discussion_r2073371179
##########
sql/connect/server/src/main/scala/org/apache/spark/sql/connect/ml/MLCache.scala:
##########
@@ -61,6 +61,31 @@ private[connect] class MLCache(sessionHolder: SessionHolder)
extends Logging {
private[ml] val totalSizeBytes: AtomicLong = new AtomicLong(0)
+ private[ml] val totalModelCacheSizeBytes: AtomicLong = new AtomicLong(0)
Review Comment:
`totalModelCacheSizeBytes ` is for counting in-memory + offloaded data size
`totalSizeBytes` is for counting in-memory size, I will rename it to
`totalInMemorySizeBytes`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
