ahshahid commented on PR #50757: URL: https://github.com/apache/spark/pull/50757#issuecomment-2848411912
I see... Some how I remembered date related SQL functions to be inDerterministic, and not allowing projects to collapse etc.. Anyways , I suppose intent is conveyed.. On Fri, May 2, 2025, 8:14 PM Mridul M ***@***.***> wrote: > ***@***.**** commented on this pull request. > ------------------------------ > > In core/src/main/scala/org/apache/spark/rdd/MapPartitionsRDD.scala > <https://github.com/apache/spark/pull/50757#discussion_r2072300212>: > > > */ > private[spark] class MapPartitionsRDD[U: ClassTag, T: ClassTag]( > var prev: RDD[T], > f: (TaskContext, Int, Iterator[T]) => Iterator[U], // (TaskContext, partition index, iterator) > preservesPartitioning: Boolean = false, > isFromBarrier: Boolean = false, > - isOrderSensitive: Boolean = false) > + isOrderSensitive: Boolean = false, > + isNonDeterministic: Boolean = false) > > Extend and override getOutputDeterministicLevel instead > > — > Reply to this email directly, view it on GitHub > <https://github.com/apache/spark/pull/50757#pullrequestreview-2813131166>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/AC6XG2EEDUV7RKGNQSPETWD24QX7TAVCNFSM6AAAAAB4DOZR32VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDQMJTGEZTCMJWGY> > . > You are receiving this because you were mentioned.Message ID: > ***@***.***> > -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
