liviazhu-db commented on code in PR #50045:
URL: https://github.com/apache/spark/pull/50045#discussion_r2070515391
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/HDFSBackedStateStoreProvider.scala:
##########
@@ -426,7 +423,7 @@ private[sql] class HDFSBackedStateStoreProvider extends
StateStoreProvider with
private lazy val loadedMaps = new util.TreeMap[Long,
HDFSBackedStateStoreMap](
Ordering[Long].reverse)
private lazy val baseDir = stateStoreId.storeCheckpointLocation()
- private lazy val fm = CheckpointFileManager.create(baseDir, hadoopConf)
+ private[spark] lazy val fm = CheckpointFileManager.create(baseDir,
hadoopConf)
Review Comment:
I'm exposing it for testing (`corruptFile`). Added a comment
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/HDFSBackedStateStoreProvider.scala:
##########
@@ -919,13 +916,13 @@ private[sql] class HDFSBackedStateStoreProvider extends
StateStoreProvider with
storeFiles
}
- private def compressStream(outputStream: DataOutputStream): DataOutputStream
= {
+ private[spark] def compressStream(outputStream: DataOutputStream):
DataOutputStream = {
Review Comment:
See above
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/HDFSBackedStateStoreProvider.scala:
##########
@@ -919,13 +916,13 @@ private[sql] class HDFSBackedStateStoreProvider extends
StateStoreProvider with
storeFiles
}
- private def compressStream(outputStream: DataOutputStream): DataOutputStream
= {
+ private[spark] def compressStream(outputStream: DataOutputStream):
DataOutputStream = {
val compressed = CompressionCodec.createCodec(sparkConf,
storeConf.compressionCodec)
.compressedOutputStream(outputStream)
new DataOutputStream(compressed)
}
- private def decompressStream(inputStream: DataInputStream): DataInputStream
= {
+ private[spark] def decompressStream(inputStream: DataInputStream):
DataInputStream = {
Review Comment:
See above
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
