sririshindra commented on code in PR #50769:
URL: https://github.com/apache/spark/pull/50769#discussion_r2070179418
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/resolver/AggregateResolver.scala:
##########
@@ -329,4 +332,17 @@ class AggregateResolver(operatorResolver: Resolver,
expressionResolver: Expressi
.candidates
.isEmpty
}
+
+ private def getGroupungAttributeIds(aggregate: Aggregate): HashSet[ExprId] =
{
Review Comment:
Ditto
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/resolver/AggregateResolver.scala:
##########
@@ -109,7 +111,8 @@ class AggregateResolver(operatorResolver: Resolver,
expressionResolver: Expressi
ExprUtils.assertValidAggregation(resolvedAggregate)
scopes.overwriteOutputAndExtendHiddenOutput(
- output = resolvedAggregate.aggregateExpressions.map(_.toAttribute)
+ output = resolvedAggregate.aggregateExpressions.map(_.toAttribute),
+ groupingAttributeIds = Some(getGroupungAttributeIds(resolvedAggregate))
Review Comment:
Typo in 'getGroupungAttributeIds'. Instead it should be
'getGroupingAttributeIds'
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
