peter-toth commented on code in PR #50757: URL: https://github.com/apache/spark/pull/50757#discussion_r2069998646
########## core/src/main/scala/org/apache/spark/rdd/RDD.scala: ########## Review Comment: 1., 2. This PR doesn't change deterministic calculation of plan nodes so it shouldn't cause more frequent plan copies. 4. IMO the point of https://github.com/apache/spark/pull/22112 is that RoundRobin partitioning is not necessairly non-deterministic, it is just order sensitive (RDD.repartition() or DF.repartition()+`spark.sql.execution.sortBeforeRepartition=false`), so the deterministic level of a stage that is followed by a RoundRobin partitioning depends on the previous stage. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
