cloud-fan commented on code in PR #50633:
URL: https://github.com/apache/spark/pull/50633#discussion_r2069841624
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/window/WindowFunctionFrame.scala:
##########
@@ -123,10 +123,7 @@ abstract class OffsetWindowFunctionFrameBase(
protected val fillDefaultValue = {
// Collect the expressions and bind them.
val boundExpressions = Seq.fill(ordinal)(NoOp) ++
expressions.toImmutableArraySeq.map { e =>
- if (e.default == null) {
Review Comment:
It's not clear to me why this is not possible to happen, and I don't think
it's worth the time to figure it out. This null check doesn't hurt at all.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
