wengh commented on code in PR #50684:
URL: https://github.com/apache/spark/pull/50684#discussion_r2069684435
##########
python/pyspark/sql/datasource.py:
##########
@@ -539,6 +539,11 @@ def pushFilters(self, filters: List["Filter"]) ->
Iterable["Filter"]:
This method is allowed to modify `self`. The object must remain
picklable.
Modifications to `self` are visible to the `partitions()` and `read()`
methods.
+ Notes
+ -----
+ Configuration `spark.sql.python.filterPushdown.enabled` must be set to
`true`
+ to implement this method.
Review Comment:
Yeah, we already show an error if it's disabled. I guess the user can find
out when they try to use the source so it's not necessary to put in the doc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
