yaooqinn commented on code in PR #50750:
URL: https://github.com/apache/spark/pull/50750#discussion_r2067728947
##########
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveExternalCatalog.scala:
##########
@@ -321,6 +321,16 @@ private[spark] class HiveExternalCatalog(conf: SparkConf,
hadoopConf: Configurat
// bucket specification to empty. Note that partition columns are
retained, so that we can
// call partition-related Hive API later.
def newSparkSQLSpecificMetastoreTable(): CatalogTable = {
+ if (table.partitionColumnNames.contains(EMPTY_DATA_SCHEMA.head.name)) {
+ // This is a valid use case but for historical reasons we don't allow
it as the 'col' name
Review Comment:
```suggestion
// TODO: SPARK-51957: Fix partition column and EMTPY_DATA_SCHEMA
naming conflict
// This is a valid use case, but for historical reason,s we don't
allow it as the 'col' name
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
