liviazhu-db commented on code in PR #50742: URL: https://github.com/apache/spark/pull/50742#discussion_r2067549146
########## sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/RocksDBStateStoreProvider.scala: ########## @@ -468,29 +511,20 @@ private[sql] class RocksDBStateStoreProvider case e: Throwable => throw QueryExecutionErrors.cannotLoadStore(e) } } + override def getStore(version: Long, uniqueId: Option[String] = None): StateStore = { + loadStateStore(version, uniqueId, readOnly = false) + } + + override def getWriteStore( + readStore: ReadStateStore, + version: Long, + uniqueId: Option[String] = None): StateStore = { + assert(version == readStore.version) + loadStateStore(version, uniqueId, readOnly = false, existingStore = Some(readStore)) Review Comment: Can you also verify that ProviderID (opId, partId, name) is the same? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org