gengliangwang commented on code in PR #50593:
URL: https://github.com/apache/spark/pull/50593#discussion_r2067477571
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala:
##########
@@ -3997,6 +3997,10 @@ class Analyzer(override val catalogManager:
CatalogManager) extends RuleExecutor
c.markAsAnalyzed(AnalysisContext.get)
case c: KeepAnalyzedQuery if c.resolved =>
c.storeAnalyzedQuery()
+ case p: LogicalPlan if p.resolved =>
Review Comment:
This is confusing, both the trait name `AnalysisAwareExpression` and the
method `markAsAnalyzed`. When the child expression is resolved, the
`DefaultValueExpression` is consider resolved. Why do we need this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
