cloud-fan commented on code in PR #50727:
URL: https://github.com/apache/spark/pull/50727#discussion_r2066410968
##########
sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/SparkExecuteStatementOperation.scala:
##########
@@ -339,7 +339,9 @@ object SparkExecuteStatementOperation {
case LongType => TTypeId.BIGINT_TYPE
case FloatType => TTypeId.FLOAT_TYPE
case DoubleType => TTypeId.DOUBLE_TYPE
- case StringType => TTypeId.STRING_TYPE
+ case _: CharType => TTypeId.CHAR_TYPE
+ case _: VarcharType => TTypeId.VARCHAR_TYPE
Review Comment:
how is it related to the alias issue?
##########
sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/SparkGetColumnsOperation.scala:
##########
@@ -184,9 +184,9 @@ private[hive] class SparkGetColumnsOperation(
case FloatType => java.sql.Types.FLOAT
case DoubleType => java.sql.Types.DOUBLE
case _: DecimalType => java.sql.Types.DECIMAL
- case StringType => java.sql.Types.VARCHAR
- case VarcharType(_) => java.sql.Types.VARCHAR
case CharType(_) => java.sql.Types.CHAR
+ case VarcharType(_) => java.sql.Types.VARCHAR
Review Comment:
ditto, though I think this is a correct fix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
