viirya commented on PR #50735: URL: https://github.com/apache/spark/pull/50735#issuecomment-2837004125
> LGTM but yeah let's probably match the impl in a followup .. (or at least match the naming from `Slice` to `Batched` or change `Batched` to `Sliced`). Thanks. @HyukjinKwon Not sure if `Batched` matches what we did for the output. IMHO, It is actually different to the input side where we did "batching" input rows but for output side, we slice the output batch (it is already batch). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
