mihailotim-db commented on code in PR #50699:
URL: https://github.com/apache/spark/pull/50699#discussion_r2063113653
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/dsl/package.scala:
##########
@@ -442,14 +442,35 @@ package object dsl extends SQLConfHelper {
otherPlan)
}
- def orderBy(sortExprs: SortOrder*): LogicalPlan = Sort(sortExprs, true,
logicalPlan)
+ def orderBy(sortExprs: SortOrder*): LogicalPlan = {
+ val sortExpressionsWithOrdinals =
sortExprs.map(replaceOrdinalsInSortOrder)
+ Sort(sortExpressionsWithOrdinals, true, logicalPlan)
+ }
+
+ def sortBy(sortExprs: SortOrder*): LogicalPlan = {
+ val sortExpressionsWithOrdinals =
sortExprs.map(replaceOrdinalsInSortOrder)
+ Sort(sortExpressionsWithOrdinals, false, logicalPlan)
+ }
- def sortBy(sortExprs: SortOrder*): LogicalPlan = Sort(sortExprs, false,
logicalPlan)
+ /**
+ * Replaces top-level integer literals from [[SortOrder]] with
[[UnresolvedOrdinal]], if
+ * `orderByOrdinal` is enabled.
+ */
+ private def replaceOrdinalsInSortOrder(sortOrder: SortOrder): SortOrder
= sortOrder match {
+ case sortOrderByOrdinal @ SortOrder(literal @ Literal(value: Int,
IntegerType), _, _, _)
+ if conf.orderByOrdinal =>
+ val ordinal = CurrentOrigin.withOrigin(literal.origin) {
UnresolvedOrdinal(value) }
Review Comment:
Looks like we don't
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
