yaooqinn commented on code in PR #50729:
URL: https://github.com/apache/spark/pull/50729#discussion_r2062514028
##########
common/utils/src/main/scala/org/apache/spark/internal/config/ConfigBuilder.scala:
##########
@@ -74,29 +69,68 @@ private object ConfigHelpers {
v.map(stringConverter).mkString(",")
}
- def timeFromString(str: String, unit: TimeUnit): Long =
JavaUtils.timeStringAs(str, unit)
+ def timeFromString(str: String, unit: TimeUnit, key: String): Long = {
+ try {
+ JavaUtils.timeStringAs(str, unit)
+ } catch {
Review Comment:
Some non-ConfigEntry callers are using this, so I handle errors here to
avoid improper INVALID_CONF_VALUE categorization for these, e.g.
- org.apache.spark.sql.execution.streaming.FileStreamOptions#maxFileAgeMs
- org.apache.spark.sql.execution.streaming.FileStreamSink#retention
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
