mihailoale-db commented on code in PR #50590:
URL: https://github.com/apache/spark/pull/50590#discussion_r2060463599
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypeExtractors.scala:
##########
@@ -314,6 +315,30 @@ case class GetArrayItem(
})
}
+ override def checkInputDataTypes(): TypeCheckResult = {
+ (left.dataType, right.dataType) match {
+ case (_: ArrayType, e2) if !e2.isInstanceOf[IntegralType] =>
Review Comment:
I would keep it for safety (so we don't throw internal error if we somehow
fail to apply type coercion rule). @cloud-fan
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
