cloud-fan commented on code in PR #50552:
URL: https://github.com/apache/spark/pull/50552#discussion_r2056374603
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/window/WindowFunctionFrame.scala:
##########
@@ -180,10 +180,20 @@ abstract class OffsetWindowFunctionFrameBase(
}
}
+ /** Indicates whether the default values are Literal values. */
+ protected lazy val onlyLiteralNulls = expressions.forall { e =>
+ e.default == null || (e.default.foldable && e.default.eval() == null)
Review Comment:
I think `e.default == null || e.default.foldable` should be good enough. As
long as the default expression does not reference any columns, we can evaluate
it in `def prepare`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
