viirya commented on code in PR #87: URL: https://github.com/apache/spark-connect-swift/pull/87#discussion_r2056415598
########## Sources/SparkConnect/DataFrame.swift: ########## @@ -733,6 +733,29 @@ public actor DataFrame: Sendable { return buildRepartition(numPartitions: numPartitions, shuffle: false) } + /// Groups the ``DataFrame`` using the specified columns, so we can run aggregation on them. + /// - Parameter cols: Grouping column names. + /// - Returns:A ``GroupedData``. + public func groupBy(_ cols: String...) -> GroupedData { + return GroupedData(self, GroupType.groupby, cols) + } + + /// Create a multi-dimensional rollup for the current ``DataFrame`` using the specified columns, so we + /// can run aggregation on them. + /// - Parameter cols: Grouping column names. + /// - Returns:A ``GroupedData``. + public func rollup(_ cols: String...) -> GroupedData { + return GroupedData(self, GroupType.rollup, cols) + } + + /// Create a multi-dimensional cube for the current ``DataFrame`` using the specified columns, so we + /// can run aggregation on them. + /// - Parameter cols: Grouping column names. + /// - Returns:A ``GroupedData``. Review Comment: ```suggestion /// - Returns: A ``GroupedData``. ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org