cloud-fan commented on code in PR #50402:
URL: https://github.com/apache/spark/pull/50402#discussion_r2056364081
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/UnionLoopExec.scala:
##########
@@ -157,9 +191,6 @@ case class UnionLoopExec(
cause = null)
}
- // Inherit stats and constraints from the dataset of the previous
iteration.
- val prevPlan = LogicalRDD.fromDataset(prevDF.queryExecution.toRdd,
prevDF, prevDF.isStreaming)
- .newInstance()
unionChildren += prevPlan
currentNumRows += prevCount.toInt
Review Comment:
not related to this PR, but `.toInt` has the risk of overflow. Shall we make
`currentNumRows` a long as well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
