mihailoale-db commented on code in PR #50676: URL: https://github.com/apache/spark/pull/50676#discussion_r2056128722
########## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala: ########## @@ -6615,7 +6615,8 @@ class AstBuilder extends DataTypeAstBuilder private def replaceIntegerLiteralWithOrdinal( expression: Expression, canReplaceWithOrdinal: Boolean = true) = expression match { - case Literal(value: Int, IntegerType) if canReplaceWithOrdinal => UnresolvedOrdinal(value) + case literal @ Literal(value: Int, IntegerType) if canReplaceWithOrdinal => Review Comment: Should we do the same in `sql/connect/server/src/main/scala/org/apache/spark/sql/connect/planner/SparkConnectPlanner.scala`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org