Ngone51 commented on code in PR #50594:
URL: https://github.com/apache/spark/pull/50594#discussion_r2055448056
##########
core/src/main/scala/org/apache/spark/util/UninterruptibleThread.scala:
##########
@@ -92,11 +110,17 @@ private[spark] class UninterruptibleThread(
* interrupted until it enters into the interruptible status.
*/
override def interrupt(): Unit = {
Review Comment:
My concern with the current solution is that it introduces unnecessary lock
contention for the thread that run out of `runUninterruptibly()`. And I'm
thinking if we could interrupt the thread more clearly, e.g.,
```scala
override def interrupt(): Unit = {
if (lock {runInUninterruptibly}) {
// interrupt as a uninterruptable thread
} else {
// interrupt as a normal thread
}
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
