cloud-fan commented on code in PR #50673:
URL: https://github.com/apache/spark/pull/50673#discussion_r2055373949
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JdbcUtils.scala:
##########
@@ -203,7 +203,11 @@ object JdbcUtils extends Logging with SQLConfHelper {
case java.sql.Types.DECIMAL | java.sql.Types.NUMERIC if scale < 0 =>
DecimalType.bounded(precision - scale, 0)
case java.sql.Types.DECIMAL | java.sql.Types.NUMERIC =>
- DecimalPrecisionTypeCoercion.bounded(precision, scale)
+ DecimalPrecisionTypeCoercion.bounded(
+ precision,
+ // A safeguard in case the JDBC scale is larger than precision which
is not supported by
+ // Spark.
+ math.min(scale, precision))
Review Comment:
```suggestion
// A safeguard in case the JDBC scale is larger than the precision
that is not supported
// by Spark.
math.max(precision, scale),
scale)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
