aokolnychyi commented on code in PR #50631: URL: https://github.com/apache/spark/pull/50631#discussion_r2054457100
########## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/constraints.scala: ########## @@ -112,6 +117,27 @@ case class CheckConstraint( with TableConstraint { // scalastyle:on line.size.limit + def toV2Constraint(isCreateTable: Boolean): Constraint = { Review Comment: I wonder if the input param should be related to the validation status, rather than to whether it is create or alter. For instance, we can make validation optional in ALTER. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org