adrians commented on PR #50170: URL: https://github.com/apache/spark/pull/50170#issuecomment-2821450242
> When there is no pushdown benefit, is there any down side of changing the physical execution from `ArrayContains` to `InSet`? I don't see any downsides: * in the worst-case: similar code is generated by the codeGen ([ArrayContains](https://github.com/apache/spark/blob/master/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala#L1498) vs [InSet](https://github.com/apache/spark/blob/master/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/predicates.scala#L695)) * in better cases, by chaining more optimizations (such as in the case with iceberg), a slightly better execution plan is achieved, since InSet is more widely supported. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
