grundprinzip commented on PR #82: URL: https://github.com/apache/spark-connect-swift/pull/82#issuecomment-2820523390
While experimenting with the client, I found another issue: It will always create a new connection and not reuse an existing connection for the session. Every time where `withGRPC` is called (https://github.com/apache/spark-connect-swift/blob/main/Sources/SparkConnect/SparkConnectClient.swift#L96) it will instantiate a new connection. It would be great to make the connection stateful because otherwise it will be a lot of overhead of establishing connections and every time doing a TLS handshake. But this can easily be addressed in a follow up PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
