peter-toth commented on code in PR #80:
URL:
https://github.com/apache/spark-connect-swift/pull/80#discussion_r2053564567
##########
Sources/SparkConnect/DataFrame.swift:
##########
@@ -521,6 +521,80 @@ public actor DataFrame: Sendable {
}
}
+ /// Join with another `DataFrame`.
+ /// Behaves as an INNER JOIN and requires a subsequent join predicate.
+ /// - Parameter right: Right side of the join operation.
+ /// - Returns: A `DataFrame`.
+ public func join(_ right: DataFrame) async -> DataFrame {
+ let right = await (right.getPlan() as! Plan).root
+ let plan = SparkConnectClient.getJoin(self.plan.root, right,
JoinType.inner)
+ return DataFrame(spark: self.spark, plan: plan)
+ }
+
+ /// Equi-join with another `DataFrame` using the given column. A cross join
with a predicate is
+ /// specified as an inner join. If you would explicitly like to perform a
cross join use the
+ /// `crossJoin` method.
+ /// - Parameters:
+ /// - right: Right side of the join operation.
+ /// - usingColumn: Name of the column to join on. This column must exist
on both sides.
+ /// - joinType: Type of join to perform. Default `inner`.
+ /// - Returns: <#description#>
Review Comment:
`#description#` is some kind of placeholder?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
