vladimirg-db commented on code in PR #50285:
URL: https://github.com/apache/spark/pull/50285#discussion_r2053490556
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/subquery.scala:
##########
@@ -67,6 +67,8 @@ abstract class PlanExpression[T <: QueryPlan[_]] extends
Expression {
*
* @param plan: the subquery plan
* @param outerAttrs: the outer references in the subquery plan
+ * @param outerScopeAttrs: the outer references in the subquery plan that
cannot be resolved
+ * in its immediate parent plan
Review Comment:
This indentation is a bit extreme
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/FunctionTableSubqueryArgumentExpression.scala:
##########
@@ -46,6 +46,10 @@ import org.apache.spark.sql.types.DataType
* relation or as a more complex logical plan in the event of a
table subquery.
* @param outerAttrs outer references of this subquery plan, generally empty
since these table
* arguments do not allow correlated references currently
+ * @param outerScopeAttrs outer references of the subquery plan that cannot be
resolved by the
Review Comment:
Can you please explain why we need to separate those? Ideally I would put
them in the same sequence, but if we really need to separate them, then the
natural way to express that would be a stack of scopes (a stack of sequences).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
