xiaonanyang-db commented on code in PR #50646:
URL: https://github.com/apache/spark/pull/50646#discussion_r2051252751
##########
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/xml/XmlVariantSuite.scala:
##########
@@ -418,14 +418,20 @@ class XmlVariantSuite extends QueryTest with
SharedSparkSession with TestXmlData
val df = createDSLDataFrame(
fileName = "books-complicated.xml",
schemaDDL = Some(
- "_id string, author string, title string, genre variant, price double,
" +
- "publish_dates variant"
+ "_id string, author string, title string, " +
+ "genre struct<genreid int, name variant>, " + // Struct with variant
+ "price variant, " + // Scalar as variant
+ "publish_dates struct<publish_date array<variant>>" // Array with
variant
Review Comment:
added tests
##########
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/xml/XmlVariantSuite.scala:
##########
@@ -418,14 +418,20 @@ class XmlVariantSuite extends QueryTest with
SharedSparkSession with TestXmlData
val df = createDSLDataFrame(
fileName = "books-complicated.xml",
schemaDDL = Some(
- "_id string, author string, title string, genre variant, price double,
" +
- "publish_dates variant"
+ "_id string, author string, title string, " +
+ "genre struct<genreid int, name variant>, " + // Struct with variant
+ "price variant, " + // Scalar as variant
+ "publish_dates struct<publish_date array<variant>>" // Array with
variant
Review Comment:
added tests below
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
